-
Notifications
You must be signed in to change notification settings - Fork 95
[Doc] improve spike_train_generation.spike_extraction parameter documentation #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Moritz-Alexander-Kern
merged 14 commits into
NeuralEnsemble:master
from
INM-6:enh/spike_extraction_documentation
Jan 14, 2025
Merged
[Doc] improve spike_train_generation.spike_extraction parameter documentation #641
Moritz-Alexander-Kern
merged 14 commits into
NeuralEnsemble:master
from
INM-6:enh/spike_extraction_documentation
Jan 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kohlerca
suggested changes
Jan 14, 2025
Collaborator
kohlerca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some suggestions for clarity in the text.
Member
Author
Moritz-Alexander-Kern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build wheels
bb0a394
into
NeuralEnsemble:master
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced description for the
spike_intervalparameter to clarify the bahavior and effects on the resulting spike train aswell as the choice of the chosen default values.Added notes section to clarify the behavior when
time_stampsis set to None and what the expected results are.This PR adresses #415 .